carrtech/ct-ops
3
0
Fork 0
Code Issues 28 Pull requests Projects Releases 750 Packages Wiki Activity Actions

fix(incidents): confirm external ticket removal #829

Merged
simon merged 1 commit from fix/incident-ticket-delete-confirm into dev 2026-06-29 09:56:32 +00:00
Conversation 0 Commits 1 Files changed 3 +55 -2
simon commented 2026-06-29 09:42:37 +00:00
Owner
Copy link

Summary

  • add a confirmation dialog before unlinking incident external tickets
  • keep the delete action scoped to the dialog confirmation
  • document the removal confirmation in CT-Ops docs

Validation

  • node --experimental-strip-types --test apps/web/lib/actions/incidents-external-tickets.test.mjs
  • corepack pnpm@10.6.5 --dir apps/web type-check
  • BETTER_AUTH_URL=https://localhost DATABASE_URL=postgres://postgres:postgres@localhost:5432/ct_ops corepack pnpm@10.6.5 --dir apps/web build
  • corepack pnpm@10.6.5 --dir apps/docs build
## Summary - add a confirmation dialog before unlinking incident external tickets - keep the delete action scoped to the dialog confirmation - document the removal confirmation in CT-Ops docs ## Validation - node --experimental-strip-types --test apps/web/lib/actions/incidents-external-tickets.test.mjs - corepack pnpm@10.6.5 --dir apps/web type-check - BETTER_AUTH_URL=https://localhost DATABASE_URL=postgres://postgres:postgres@localhost:5432/ct_ops corepack pnpm@10.6.5 --dir apps/web build - corepack pnpm@10.6.5 --dir apps/docs build
fix(incidents): confirm external ticket removal
All checks were successful
Conventional PR title / Conventional PR title (pull_request) Successful in 0s
Details
PR Checks (Docker images) / Ansible API contract (pull_request) Successful in 7s
Details
PR Checks (Docker images) / Detect Docker image changes (pull_request) Successful in 8s
Details
SAST / Detect security scan scope (pull_request) Successful in 8s
Details
SAST / gosec (agent) (pull_request) Has been skipped
Details
PR Checks (Docker images) / Ingest Docker image (pull_request) Has been skipped
Details
PR Checks (Docker images) / Ansible API Docker image (pull_request) Has been skipped
Details
SAST / gosec (ingest) (pull_request) Has been skipped
Details
SAST / trivy (filesystem) (pull_request) Has been skipped
Details
Secret Scan / gitleaks (pull_request) Successful in 27s
Details
SAST / trivy (config / IaC) (pull_request) Has been skipped
Details
SAST / semgrep (pull_request) Successful in 1m11s
Details
SAST / crypto-lint (no weak hashes / ciphers) (pull_request) Successful in 1m6s
Details
PR Checks (Web) / Web (lint / type-check / build) (pull_request) Successful in 2m36s
Details
PR Checks (Docker images) / Web Docker image (pull_request) Successful in 12m28s
Details
e34aa6201f
simon deleted branch fix/incident-ticket-delete-confirm 2026-06-29 09:56:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
E2E Failure
Regression found by end-to-end automation

  
area:agent
Go agent

  
area:audit-log
Audit logging

  
area:auth
Authentication

  
area:authz
Authorisation / RBAC

  
area:ci
CI / tooling / scanning

  
area:crypto
Cryptography / secrets

  
area:db
Database / schema

  
area:docker
Docker / deployment

  
area:headers
HTTP headers / CSP

  
area:ingest
gRPC ingest service

  
area:ldap
LDAP integration

  
area:rate-limit
Rate limiting / abuse prevention

  
area:ssrf
Server-side request forgery

  
area:supply-chain
Supply chain / deploy

  
area:terminal
Terminal / PTY

  
autorelease: pending

   
autorelease: tagged

   
bug
Something isn't working

  
claude-working

   
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
priority: critical
Critical - blocking or data loss

  
priority: high
High priority - should be addressed soon

  
priority: low
Low priority - nice to have

  
priority: medium
Medium priority - address after high priority items

  
question
Further information is requested

  
security
Security finding from pre-pentest audit

  
sev:critical
Severity: Critical

  
sev:high
Severity: High

  
sev:info
Severity: Informational / Hardening

  
sev:low
Severity: Low

  
sev:medium
Severity: Medium

  
tests-required
Needs tests or stronger coverage before fix is complete

  
wontfix
This will not be worked on

No labels
E2E Failure
area:agent
area:audit-log
area:auth
area:authz
area:ci
area:crypto
area:db
area:docker
area:headers
area:ingest
area:ldap
area:rate-limit
area:ssrf
area:supply-chain
area:terminal
autorelease: pending
autorelease: tagged
bug
claude-working
documentation
duplicate
enhancement
good first issue
help wanted
invalid
priority: critical
priority: high
priority: low
priority: medium
question
security
sev:critical
sev:high
sev:info
sev:low
sev:medium
tests-required
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
carrtech/ct-ops!829
No description provided.