carrtech/ct-ops

Fork 0

fix(web): activate existing workspace tabs from links #761

Merged

simon merged 1 commit from fix/reopen-existing-tabs into dev

2026-06-23 14:20:27 +00:00

simon commented

2026-06-23 14:06:01 +00:00

Owner

Summary\n- route same-origin links clicked inside workspace panels through the workspace tab activator when the destination tab already exists\n- preserve normal browser/Next navigation for new routes, modified clicks, external links, downloads, and hash-only same-page links\n- add workspace tab regression coverage plus a dashboard E2E scenario for the reported Active alerts flow\n\n## Validation\n- pnpm install --frozen-lockfile\n- node --experimental-strip-types --test apps/web/lib/workspace-tabs/state.test.mjs\n- pnpm --dir apps/web type-check\n- pnpm --dir apps/web lint (passes with existing warnings outside this change)\n- pnpm --dir apps/web test:unit -- lib/workspace-tabs/state.test.mjs\n- BETTER_AUTH_URL=http://localhost:3000 DATABASE_URL=postgresql://ctops:ctops@localhost:5432/ctops pnpm --dir apps/web build\n\n## E2E note\n- pnpm --dir apps/web test:e2e tests/e2e/dashboard/workspace-tabs.spec.ts is currently blocked before app render by issue #760: Webpack tries to parse the native cpu-features binding from the existing ssh2/host-editor import path.

## Summary\n- route same-origin links clicked inside workspace panels through the workspace tab activator when the destination tab already exists\n- preserve normal browser/Next navigation for new routes, modified clicks, external links, downloads, and hash-only same-page links\n- add workspace tab regression coverage plus a dashboard E2E scenario for the reported Active alerts flow\n\n## Validation\n- pnpm install --frozen-lockfile\n- node --experimental-strip-types --test apps/web/lib/workspace-tabs/state.test.mjs\n- pnpm --dir apps/web type-check\n- pnpm --dir apps/web lint (passes with existing warnings outside this change)\n- pnpm --dir apps/web test:unit -- lib/workspace-tabs/state.test.mjs\n- BETTER_AUTH_URL=http://localhost:3000 DATABASE_URL=postgresql://ctops:ctops@localhost:5432/ctops pnpm --dir apps/web build\n\n## E2E note\n- pnpm --dir apps/web test:e2e tests/e2e/dashboard/workspace-tabs.spec.ts is currently blocked before app render by issue #760: Webpack tries to parse the native cpu-features binding from the existing ssh2/host-editor import path.

simon added 1 commit

2026-06-23 14:06:01 +00:00

fix(web): activate existing workspace tabs from links

Conventional PR title / Conventional PR title (pull_request) Successful in 0s

Details

PR Checks (Docker images) / Ansible API contract (pull_request) Successful in 6s

Details

SAST / Detect security scan scope (pull_request) Successful in 8s

Details

PR Checks (Docker images) / Detect Docker image changes (pull_request) Successful in 8s

Details

SAST / gosec (agent) (pull_request) Has been skipped

Details

PR Checks (Docker images) / Ansible API Docker image (pull_request) Has been skipped

Details

PR Checks (Docker images) / Ingest Docker image (pull_request) Has been skipped

Details

SAST / gosec (ingest) (pull_request) Has been skipped

Details

SAST / trivy (filesystem) (pull_request) Has been skipped

Details

Secret Scan / gitleaks (pull_request) Successful in 27s

Details

SAST / trivy (config / IaC) (pull_request) Has been skipped

Details

SAST / crypto-lint (no weak hashes / ciphers) (pull_request) Successful in 1m7s

Details

SAST / semgrep (pull_request) Successful in 1m11s

Details

PR Checks (Web) / Web (lint / type-check / build) (pull_request) Successful in 2m24s

Details

PR Checks (Docker images) / Web Docker image (pull_request) Successful in 12m39s

Details

ebd89e9693

simon merged commit db9fcd4678 into dev

2026-06-23 14:20:27 +00:00

simon deleted branch fix/reopen-existing-tabs

2026-06-23 14:20:27 +00:00

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

carrtech/ct-ops!761

No description provided.

Rows
Columns