carrtech/ct-ops
3
0
Fork 0
Code Issues 28 Pull requests Projects Releases 750 Packages Wiki Activity Actions

fix(web): keep linked service graph roots together #539

Closed
simon wants to merge 1 commit from fix/service-graph-link-gravity into main
pull from: fix/service-graph-link-gravity
merge into: carrtech:main
Conversation 1 Commits 1 Files changed 3 +135 -4
simon commented 2026-06-07 18:44:23 +00:00
Owner
Copy link

Summary

  • pass ITIL service dependency edges into the service graph layout helper
  • group dependency-linked root service trees together before assigning positions
  • remove the extra root spacer only between adjacent linked root trees so connected services render closer together
  • add a layout regression test for a cross-root service dependency

Validation

  • node --experimental-strip-types --test apps/web/lib/services/service-graph-layout.test.mjs
  • pnpm --filter web type-check
  • pnpm --filter web exec eslint lib/services/service-graph-layout.ts lib/services/service-graph-layout.test.mjs app/(dashboard)/services/service-graph.tsx
  • pnpm --filter web test:unit
  • pnpm --filter web lint (passes with existing warnings tracked by #521)
  • BETTER_AUTH_URL=http://localhost:3000 DATABASE_URL=postgresql://ctops:ctops@localhost:5432/ctops pnpm --filter web build (passes; unrelated Turbopack NFT trace warning tracked by #538)

Notes

This keeps the layout deterministic rather than adding a runtime physics simulation. Dependency-linked root groups are pulled together during static layout, while unrelated roots retain the existing spacing.

## Summary - pass ITIL service dependency edges into the service graph layout helper - group dependency-linked root service trees together before assigning positions - remove the extra root spacer only between adjacent linked root trees so connected services render closer together - add a layout regression test for a cross-root service dependency ## Validation - `node --experimental-strip-types --test apps/web/lib/services/service-graph-layout.test.mjs` - `pnpm --filter web type-check` - `pnpm --filter web exec eslint lib/services/service-graph-layout.ts lib/services/service-graph-layout.test.mjs app/(dashboard)/services/service-graph.tsx` - `pnpm --filter web test:unit` - `pnpm --filter web lint` (passes with existing warnings tracked by #521) - `BETTER_AUTH_URL=http://localhost:3000 DATABASE_URL=postgresql://ctops:ctops@localhost:5432/ctops pnpm --filter web build` (passes; unrelated Turbopack NFT trace warning tracked by #538) ## Notes This keeps the layout deterministic rather than adding a runtime physics simulation. Dependency-linked root groups are pulled together during static layout, while unrelated roots retain the existing spacing.
fix(web): keep linked service graph roots together
All checks were successful
Conventional PR title / Conventional PR title (pull_request) Successful in 0s
Details
PR Checks (Docker images) / Ansible API contract (pull_request) Successful in 7s
Details
PR Checks (Docker images) / Detect Docker image changes (pull_request) Successful in 9s
Details
Customer bundle check / validate (pull_request) Successful in 15s
Details
PR Checks (Docker images) / Ingest Docker image (pull_request) Has been skipped
Details
PR Checks (Docker images) / Ansible API Docker image (pull_request) Has been skipped
Details
Secret Scan / gitleaks (pull_request) Successful in 27s
Details
SAST / crypto-lint (no weak hashes / ciphers) (pull_request) Successful in 1m6s
Details
SAST / semgrep (pull_request) Successful in 1m12s
Details
SAST / gosec (agent) (pull_request) Successful in 1m59s
Details
SAST / trivy (filesystem) (pull_request) Successful in 2m8s
Details
SAST / gosec (ingest) (pull_request) Successful in 2m9s
Details
SAST / trivy (config / IaC) (pull_request) Successful in 2m1s
Details
PR Checks (Web) / Web (lint / type-check / build) (pull_request) Successful in 2m38s
Details
PR Checks (Docker images) / Web Docker image (pull_request) Successful in 7m52s
Details
220ce280d4
simon commented 2026-06-07 19:07:41 +00:00
Author
Owner
Copy link

Landed on main as aefac91c after fj merge returned 405, then released via web/v0.234.1 and bundle/v0.103.1.

Landed on main as aefac91c after fj merge returned 405, then released via web/v0.234.1 and bundle/v0.103.1.
simon closed this pull request 2026-06-07 19:07:41 +00:00
All checks were successful
Conventional PR title / Conventional PR title (pull_request) Successful in 0s
Details
PR Checks (Docker images) / Ansible API contract (pull_request) Successful in 7s
Details
PR Checks (Docker images) / Detect Docker image changes (pull_request) Successful in 9s
Details
Customer bundle check / validate (pull_request) Successful in 15s
Details
PR Checks (Docker images) / Ingest Docker image (pull_request) Has been skipped
Details
PR Checks (Docker images) / Ansible API Docker image (pull_request) Has been skipped
Details
Secret Scan / gitleaks (pull_request) Successful in 27s
Details
SAST / crypto-lint (no weak hashes / ciphers) (pull_request) Successful in 1m6s
Details
SAST / semgrep (pull_request) Successful in 1m12s
Details
SAST / gosec (agent) (pull_request) Successful in 1m59s
Details
SAST / trivy (filesystem) (pull_request) Successful in 2m8s
Details
SAST / gosec (ingest) (pull_request) Successful in 2m9s
Details
SAST / trivy (config / IaC) (pull_request) Successful in 2m1s
Details
PR Checks (Web) / Web (lint / type-check / build) (pull_request) Successful in 2m38s
Details
PR Checks (Docker images) / Web Docker image (pull_request) Successful in 7m52s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
E2E Failure
Regression found by end-to-end automation

  
area:agent
Go agent

  
area:audit-log
Audit logging

  
area:auth
Authentication

  
area:authz
Authorisation / RBAC

  
area:ci
CI / tooling / scanning

  
area:crypto
Cryptography / secrets

  
area:db
Database / schema

  
area:docker
Docker / deployment

  
area:headers
HTTP headers / CSP

  
area:ingest
gRPC ingest service

  
area:ldap
LDAP integration

  
area:rate-limit
Rate limiting / abuse prevention

  
area:ssrf
Server-side request forgery

  
area:supply-chain
Supply chain / deploy

  
area:terminal
Terminal / PTY

  
autorelease: pending

   
autorelease: tagged

   
bug
Something isn't working

  
claude-working

   
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
priority: critical
Critical - blocking or data loss

  
priority: high
High priority - should be addressed soon

  
priority: low
Low priority - nice to have

  
priority: medium
Medium priority - address after high priority items

  
question
Further information is requested

  
security
Security finding from pre-pentest audit

  
sev:critical
Severity: Critical

  
sev:high
Severity: High

  
sev:info
Severity: Informational / Hardening

  
sev:low
Severity: Low

  
sev:medium
Severity: Medium

  
tests-required
Needs tests or stronger coverage before fix is complete

  
wontfix
This will not be worked on

No labels
E2E Failure
area:agent
area:audit-log
area:auth
area:authz
area:ci
area:crypto
area:db
area:docker
area:headers
area:ingest
area:ldap
area:rate-limit
area:ssrf
area:supply-chain
area:terminal
autorelease: pending
autorelease: tagged
bug
claude-working
documentation
duplicate
enhancement
good first issue
help wanted
invalid
priority: critical
priority: high
priority: low
priority: medium
question
security
sev:critical
sev:high
sev:info
sev:low
sev:medium
tests-required
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
carrtech/ct-ops!539
No description provided.