fix(monitoring): show relevant check history metrics #461

Merged
simon merged 1 commit from fix/check-history-metrics into main 2026-06-05 10:04:25 +00:00
Owner

Summary

  • choose history bar metrics per check type instead of always using response time
  • show folder/file/volume size, cert expiry days, discovery counts, patch update counts, or endpoint response time as appropriate
  • add focused unit coverage for the metric selection logic

Validation

  • node --experimental-strip-types --test apps/web/lib/checks/history-chart.test.mjs
  • pnpm --filter web type-check
  • pnpm --filter web lint (passes with existing warnings)
  • pnpm --filter web test:unit (fails in unrelated source-regex tests; filed #460)
## Summary - choose history bar metrics per check type instead of always using response time - show folder/file/volume size, cert expiry days, discovery counts, patch update counts, or endpoint response time as appropriate - add focused unit coverage for the metric selection logic ## Validation - node --experimental-strip-types --test apps/web/lib/checks/history-chart.test.mjs - pnpm --filter web type-check - pnpm --filter web lint (passes with existing warnings) - pnpm --filter web test:unit (fails in unrelated source-regex tests; filed #460)
fix(monitoring): show relevant check history metrics
All checks were successful
Conventional PR title / Conventional PR title (pull_request) Successful in 0s
PR Checks (Docker images) / Ansible API contract (pull_request) Successful in 10s
PR Checks (Docker images) / Detect Docker image changes (pull_request) Successful in 13s
Secret Scan / gitleaks (pull_request) Successful in 29s
SAST / semgrep (pull_request) Successful in 1m17s
SAST / crypto-lint (no weak hashes / ciphers) (pull_request) Successful in 1m10s
PR Checks (Docker images) / Ingest Docker image (pull_request) Has been skipped
PR Checks (Docker images) / Ansible API Docker image (pull_request) Has been skipped
SAST / gosec (agent) (pull_request) Successful in 2m10s
SAST / gosec (ingest) (pull_request) Successful in 2m14s
SAST / trivy (filesystem) (pull_request) Successful in 2m7s
SAST / trivy (config / IaC) (pull_request) Successful in 2m4s
PR Checks (Web) / Web (lint / type-check / build) (pull_request) Successful in 2m47s
PR Checks (Docker images) / Web Docker image (pull_request) Successful in 9m56s
a41e1299db
simon merged commit 44ed2a41f0 into main 2026-06-05 10:04:25 +00:00
simon deleted branch fix/check-history-metrics 2026-06-05 10:04:26 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
carrtech/ct-ops!461
No description provided.