carrtech/ct-ops

Fork 0

test(web): credential wizard source assertion rejects repository privateKey field #331

New issue

Open

opened 2026-05-31 17:57:49 +00:00 by simon · 0 comments

simon commented

2026-05-31 17:57:49 +00:00

Owner

While validating the repository SSH key error handling fix, I ran the full web unit suite with dependencies installed:\n\npnpm --filter web test:unit\n\nThe suite currently fails in apps/web/lib/automation/ct-automation-credential-step-core.test.mjs at the "credential wizard UI and actions stay browser safe" source assertion. The test asserts the CT-Automation jobs client does not contain privateKey, but the same client now legitimately includes repository-management fields such as privateKeyVisible, name="privateKey", and calls to repository create/test actions that pass repository SCM private key form data.\n\nEvidence from the focused run:\n\n- File: apps/web/lib/automation/ct-automation-credential-step-core.test.mjs:294\n- Failing assertion: assert.doesNotMatch(client, /privateKey/)\n- Source containing the match: apps/web/app/(dashboard)/automation/jobs/ct-automation-jobs-client.tsx repository private-key UI and form submission fields\n\nExisting related full-suite failures are already tracked separately as #21, #283, and #284. This one should be narrowed so credential tests only forbid credential secret leakage instead of forbidding repository private-key form field names in the shared jobs client.

While validating the repository SSH key error handling fix, I ran the full web unit suite with dependencies installed:\n\n`pnpm --filter web test:unit`\n\nThe suite currently fails in `apps/web/lib/automation/ct-automation-credential-step-core.test.mjs` at the "credential wizard UI and actions stay browser safe" source assertion. The test asserts the CT-Automation jobs client does not contain `privateKey`, but the same client now legitimately includes repository-management fields such as `privateKeyVisible`, `name="privateKey"`, and calls to repository create/test actions that pass repository SCM private key form data.\n\nEvidence from the focused run:\n\n- File: `apps/web/lib/automation/ct-automation-credential-step-core.test.mjs:294`\n- Failing assertion: `assert.doesNotMatch(client, /privateKey/)`\n- Source containing the match: `apps/web/app/(dashboard)/automation/jobs/ct-automation-jobs-client.tsx` repository private-key UI and form submission fields\n\nExisting related full-suite failures are already tracked separately as #21, #283, and #284. This one should be narrowed so credential tests only forbid credential secret leakage instead of forbidding repository private-key form field names in the shared jobs client.

simon referenced this issue

2026-05-31 17:58:38 +00:00

fix(web): validate repository SSH keys #332

simon referenced this issue

2026-06-04 14:56:53 +00:00

feat(automation): label trial runs in history #428

No Branch/Tag specified

main

dev

release-please--branches--main

feat/log-error-purge

ci/forgejo-ansible-api-debian

ci/forgejo-nexus-docker-proxy-apk

ci/forgejo-nexus-docker-proxy

chore/sync-shared-agent-instructions-25823681308

fix/agent-token-url-modal

chore/sync-shared-agent-instructions-25823634922

codex/fix-docker-inventory-conn-busy

codex/docker-host-retention-done

codex/docker-host-retention

codex/docker-global-retention

codex/fix-ansible-host-log-scope

codex/fix-people-direct-signups

codex/show-unscoped-pending-users

codex/fix-people-after-org-removal

codex/remove-org-task-11-run8

codex/fix-dashboard-instance-scope

codex/remove-org-task-11-run6

codex/remove-org-task-5-run3

codex/remove-org-task2-auth-onboarding

codex/remove-org-task1-reset-schema

fix/install-api-403

fix/bundle-agent-0343

fix/agent-self-update-release-probe

fix/web-release-self-update-cert

fix/agent-self-update-download-tls

fix/patch-age-calendar-days

codex/carrtech-ct-ops-brand

fix/auth-2fa-login-action

perf/password-manager-user-experience

codex/legal-notice-licence-tiers

codex/legal-risk-disclaimer

feat/password-manager-task15-e2e-v2

feat/password-manager-route-shell

codex/task7-password-manager-bundle-v2

fix/bug-scan-agent-org-token

fix/issue-908-ldap-2fa-run2

fix/issue-908-ldap-2fa

fix/issue-888-notification-access

copilot/fix-privileged-server-actions

copilot/fix-slack-webhook-credential-exposure

copilot/fix-cross-user-inbox-access

copilot/fix-drizzle-migration-metadata-drift

chore/sync-shared-agent-instructions-25329056889

chore/sync-shared-agent-instructions-25326253587

feat/password-vault-schema

docs/password-vault-architecture

chore/sync-shared-agent-instructions-25313095713

chore/sync-shared-agent-instructions-25312041197

docs/remove-ct-passwd-plan

docs/ct-passwd-dedicated-repo-note

automation/impliment-ct-passwd

feat/licence-verifier-key-rotation

docs/ct-passwd-implementation-plan

fix/seat-licence-activation-refresh

fix/upgrade-licence-key-perms

fix/upgrade-missing-backup

fix/force-web-licence-key-release

fix/release-fetch-licence-public-key

feat/licence-public-key-repo

fix/invite-membership

feat/ct-ops-seat-expiry-admission

fix/start-tls-dir-permissions

fix/web-entrypoint-postgres-env

codex/add-upgrade-helper

codex/fix-installer-web-release

fix/install-db-url-password

docs/plugin-auth-licensing

docs/ct-cve-final-residue-audit

fix/web-release-cve-cleanup

fix/ct-cve-release-guidance

feat/ct-cve-residue-audit

feat/remove-ct-cve-source-settings

feat/ct-cve-connector-setup-ui

feat/ct-cve-gui-logs

feat/ct-cve-next-task

codex/fix-auth-cookie-redirect-loop

fix/auth-redirect-loop

feat/ct-cve-connection-status

feat/ct-cve-inventory-export

feat/ct-cve-finding-ingest

feat/ct-ops-ct-cve-connector

feat/ct-cve-source-config-ui

feat/ct-cve-gui-phase8

docs/track-ct-cve-distro-sync

ct-cve-phase7-next

docs/track-ct-cve-feed-sync

ct-cve-next-slice

docs/track-ct-cve-release-publishing

docs/ct-cve-dependent-product-plan

feat/ct-cve-bootstrap

ct-cve-api-contract

docs/licensing-ui-seat-docs

docs/migration-coordination-refresh

feat/remove-pro-core-gates

feat/remove-pro-gates

feat/seat-capacity-model

docs/migration-plan-cleanup-rule

feat/seat-enforcement

docs/free-enterprise-seat-licensing

docs/ct-cve-migration-plan

automation/create-e2e-tests-for-ct-ops-20260429n

codex/tighten-rpm-version-compare

codex/redhat-csaf-package-ingest

automation/create-e2e-tests-for-ct-ops-20260429m

automation/create-e2e-tests-for-ct-ops-20260429k

fix/delete-host-patch-status

automation/create-e2e-tests-for-ct-ops-20260429j

fix/enrolment-token-command

automation/create-e2e-tests-for-ct-ops-20260429i

automation/create-e2e-tests-for-ct-ops-20260429T090218Z

automation/create-e2e-tests-for-ct-ops-20260429g

codex/rhel-compatible-rpm-hosts

codex/confirmed-linux-cve-matching

automation/create-e2e-tests-for-ct-ops-20260429f

fix/issue-760-tooling-role-gate

fix/agent-update-version-discovery

automation/create-e2e-tests-for-ct-ops-20260429e2

automation/create-e2e-tests-for-ct-ops-20260429e

codex/create-e2e-tests-for-ct-ops-20260429

fix/issue-743-install-token-leak

automation/create-e2e-tests-for-ct-ops-20260429d

automation/create-e2e-tests-for-ct-ops-20260429c

daily-bug-scan-20260429

automation/create-e2e-tests-for-ct-ops-20260429b

test/web-e2e-coverage-20260429

codex/create-e2e-tests-for-ct-ops-20260428run3

automation/create-e2e-tests-for-ct-ops-20260428run2

automation/create-e2e-tests-for-ct-ops-20260428z

codex/build-docs-rich-editor

automation/create-e2e-tests-for-ct-ops-20260428k

feat/vulnerability-detail-modal

fix/web-directory-lookup-e2e-release

automation/create-e2e-tests-for-ct-ops-20260428j

feat/vulnerability-management-interface

fix/web-certificate-checker-private-targets

feat/admin-ingest-status

automation/create-e2e-tests-for-ct-ops-20260428i

automation/create-e2e-tests-for-ct-ops-20260428h

codex/build-docs-capability

feat/linux-cve-checking

automation/create-e2e-tests-for-ct-ops-20260428g

fix/password-reset-smtp-relay

automation/create-e2e-tests-for-ct-ops-20260428f

feat/support-data-script

codex/create-e2e-tests-for-ct-ops

fix/agent-auto-update

feat/patch-status-report

codex/create-e2e-tests-for-ct-ops-20260428-100235

fix/move-network-tab

fix/web-admin-e2e-release

automation/create-e2e-tests-for-ct-ops-20260428090108

feat/admin-layout

automation/create-e2e-tests-for-ct-ops-20260428e

fix/e2e-auth-session-harness

feat/smtp-relay-test-recipient

codex/create-e2e-tests-for-ct-ops-20260428

automation/create-e2e-tests-for-ct-ops-20260428c

automation/create-e2e-tests-for-ct-ops-20260428b

automation/create-e2e-tests-for-ct-ops-20260428

feat/e2e-coverage-20260428

codex/create-e2e-tests-for-ct-ops-20260428-000235

fix/docs-pnpm-install-eagain

feat/central-smtp-settings

automation/create-e2e-tests-for-ct-ops-20260427

codex/email-verification-resend

docs/conventional-pr-titles

feat/notification-purge

docs/agents-worktree-instructions

codex/optional-email-verification

codex/add-test-completion-rule

codex/update-agent-security-rules

fix/issue-319-agent-config-perms

automation/create-e2e-tests-for-ct-ops

codex/fix-customer-bundle-image-ref-export

fix/web-docker-pnpm-retry

codex/fix-agent-heartbeat-jwt

codex/ssh-backed-terminal-access

automation/e2e-coverage-20260426

fix/bundle-transfer-mtls

fix/bundle-transfer-streaming

feat/bundle-transfer

fix/issue-274-session-auth

fix/bundle-transfer-route-types

feat/gitlab-latest-target

fix/pin-buildkit-image

feature/gitlab-bundler

fix/plugin-download-status

fix/web-installer-release-checks

fix/installer-release-bundle

claude/jenkins-plugin-dependency-test-GRblf

claude/jenkins-bundler-offline-script

claude/validate-jenkins-java-compatibility-5ee9d

claude/ingest-slowloris-fix

claude/jenkins-bundler-java-and-war-only

claude/release-event-trigger-recovery

claude/fix-release-docker-publish-dispatch

claude/debug-github-actions-HrpO8

claude/fix-duplicate-builds-0pL35

claude/jenkins-plugin-automation-pMCDp

claude/resolve-pr520-conflicts-LPXcm

claude/debug-github-actions-aH3Ce

claude/cleanup-github-actions-runners-wy27V

claude/fix-install-script-skip-verify

claude/fix-nginx-tls-init

claude/verify-secure-comms-MIPad

claude/debug-agent-install-3zc05

claude/add-mtls-security-PWQM7

feat/bake-agent-binaries-into-web-image

chore/rename-to-ct-ops

security/grpc-limits-jwt-symlink-perms

claude/fix-cloudflare-tunnel-terminal-ZVhJB

ci/self-hosted-runners

claude/pensive-dijkstra-6dd249

fix/ingest-dockerfile-harden

claude/github-issue-work-MkOq4

claude/fix-cloudflare-origin-error-IzjG1

claude/sweet-buck-4ebfe3

claude/add-support-uploads-qzgsl

claude/amazing-austin-35334d

claude/add-doc-reference-links-n6WPJ

feat/support-admin-health

feat/support-ticket-autorefresh

feat/support-markdown-rendering

fix/support-ai-trees-search

fix/support-worker-tool-logging

fix/support-worker-env

chore/support-env-example

claude/amazing-zhukovsky-65a873

claude/agent-windows-eventlog

claude/nervous-cannon-2c1634

claude/plan-ct-ops-features-SAqqo

fix/issue-357-agent-log-mode

fix/issue-352-timing-safe-comparisons

fix/issue-348-drop-sha1-fingerprint

fix/issue-350-env-example-comments

fix/issue-349-dev-tls-cert-expiry

fix/dependabot-broaden-major-ignores

fix/react-hooks-set-state-in-effect

fix/361-sast-scans

fix/363-secret-scanning

fix/364-sbom-per-release

fix/362-dependabot-config

fix/360-security-disclosure-policy

claude/thirsty-edison-812951

claude/condescending-gagarin-4aafe0

claude/romantic-volhard-f6eb45

claude/zealous-spence-f524ef

claude/cool-matsumoto-cf7094

claude/stripe-price-source-of-truth

claude/flat-pricing-no-seats

claude/mystifying-lichterman-e5b806

claude/distracted-ishizaka-91a269

claude/fix-deploy-docs-package-filter

claude/remove-licence-public-key-override

claude/recursing-yalow-0cd636

claude/amazing-kare-6c9f0d

claude/github-issues-Gxgxu

claude/improve-readme-Yb7v7

claude/github-issue-j7rds

fix/c09-delete-certificate-auth-check

fix/licence-purchase-contact-display

fix/licence-purchase-bootstrap-org

claude/recursing-driscoll-2d51a4

feat/notes-data-layer

claude/confident-heyrovsky-7750cb

feat/command-palette-scaffold

claude/competent-vaughan-38eeea

claude/keen-nobel-d2f362

claude/practical-ramanujan-275b00

revert/remove-podman-support

fix/rootless-podman-session-check

fix/podman-compose-compat

fix/podman-compose-missing-provider

claude/frosty-grothendieck-03ca48

claude/competent-roentgen-d7b502

claude/zen-wright-dfe08f

feat/podman-runtime-detection

claude/determined-rosalind-475a9a

claude/fix-ramp-sem-leak

claude/fix-connpool-negative-index

claude/fix-runid-test-flake

claude/loadtest-admin-key-forward

claude/cool-spence-511593

claude/nice-galileo-ea5007

claude/dreamy-knuth-258473

claude/fix-enrolment-url-env-JS3qR

claude/cert-checker-paste-and-key-input

claude/ssl-certificate-checker-kvI78

claude/update-start-sh-repo-CaoP7

claude/elated-taussig-d1af01

claude/work-github-issue-mi6fu

feat/directory-lookup-improvements

claude/funny-yalow-44f103

fix/directory-lookup-error-surfacing

feat/directory-lookup

docs/networks-graph-vuepress

feat/terminal-font-size

feat/terminal-tabs-and-splits

copilot/add-tty-terminal-capability

feat/network-graph-dashed-edges

feat/network-graph-animated-edges

feat/networks

copilot/fix-system-diagram-image-aspect-ratio

feat/migrate-docs-to-vuepress

fix/deploy-docs-pnpm-version

gh-pages

feat/docusaurus-docs-site

fix/export-rate-limit-and-error-modal

fix/software-report-chart-darkmode

feat/software-report-charts-firstseen

feat/software-report-unified-table

fix/delete-host-software-scans-fk

fix/delete-host-cascade

fix/delete-host-notifications-fk

fix/jwt-key-db-persistence

fix/inventory-failed-scan-visibility

fix/inventory-scan-polling

feat/software-report-improvements

fix/monitoring-cpu-spikes-and-alert-evaluation

fix/software-report-select-empty-value

fix/reports-fragment-keys

fix/windows-registry-import-conflict

feature/software-inventory

fix/agent-uninstall-cgroup-escape

feature/host-delete-uninstall-agent

feature/terminal-fixed-bottom

feature/host-notification-charts

feature/notification-trend-timerange

fix/notification-chart-axis-labels

feature/notification-improvements

feature/notification-channels

feature/terminal-ux-improvements

feature/terminal-persist-tabs

fix/terminal-panel-provider-scope

feature/terminal-panel-tabs

fix/terminal-login-auth

feature/terminal-per-user-auth

fix/terminal-shell-env-and-alma

fix/terminal-heartbeat-response-push

fix/terminal-agent-connection-diagnostics

fix/terminal-xterm-hidden-container

fix/terminal-heartbeat-and-ws-url

feat/chart-zoom-metrics-bucketing

docs/progress-update-sessions-21-27

feat/106-agent-task-framework

feat/105-host-groups

feat/101-token-list-copy-actions

fix/92-ldap-cert-preview-height

fix/92-ldap-cert-textarea-overflow

fix/heartbeat-liveness-check

fix/enrollment-token-usage-count

feat/agent-uninstall

feat/phase4-service-accounts

fix/agent-checks-reliability

fix/ci-agent-dist-missing

feat/phase2-complete-session15

claude/youthful-blackwell

fix/agent-heartbeat-backoff-reset

ci/inline-customer-bundle

fix/customer-bundle-dispatch

feat/customer-bundle

fix/ingest-bake-manifest-no-source-deps

fix/agent-self-update-restart

ci/docker-multi-arch

fix/start-pull-from-ghcr

copilot/explain-repository-structure

feat/agent-version-flag-and-ui-version

feat/alert-rules-and-notifications

release-please--branches--main--components--agent

feat/host-realtime-sse

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

carrtech/ct-ops#331

No description provided.

Rows
Columns